build: fix error in size check tests #20808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an error that was being thrown in the size checking tests, because a file can't be resolved through `angular_material/tools/angular_ivy_enabled` anymore. With these changes the file is resolved relatively by looking for the closest `bin` directory and constructing the path from there. It's unclear how long the change has been failing for, because it isn't set up to break the CI. These changes also update the expected sizes since they were outdated.
google-cla
bot
added
the
cla: yes
crisbeto
requested review from
devversion,
jelbourn and
a team
as code owners
crisbeto
added
merge safe
P3
annieyw
pushed a commit
that referenced
this pull request
Oct 16, 2020
Fixes an error that was being thrown in the size checking tests, because a file can't be resolved through `angular_material/tools/angular_ivy_enabled` anymore. With these changes the file is resolved relatively by looking for the closest `bin` directory and constructing the path from there. It's unclear how long the change has been failing for, because it isn't set up to break the CI. These changes also update the expected sizes since they were outdated. (cherry picked from commit 5e9e41b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error that was being thrown in the size checking tests, because a file can't be resolved through
angular_material/tools/angular_ivy_enabledanymore. With these changes the file is resolved relatively by looking for the closestbindirectory and constructing the path from there.It's unclear how long the change has been failing for, because it isn't set up to break the CI.
These changes also update the expected sizes since they were outdated.