Skip to content

refactor(material-experimental/mdc-table): share code between MDC and non-MDC versions of MatTableDataSource #20929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2020
Merged

refactor(material-experimental/mdc-table): share code between MDC and non-MDC versions of MatTableDataSource #20929

merged 3 commits into from
Nov 24, 2020

Conversation

mmalerba
Copy link
Contributor

blocked on #20924

@mmalerba mmalerba requested review from jelbourn and crisbeto October 29, 2020 23:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 29, 2020
crisbeto
crisbeto reviewed Oct 30, 2020
View reviewed changes
@mmalerba mmalerba force-pushed the mat-table-ds branch 3 times, most recently from 30302a7 to 0ddf3e8 Compare October 30, 2020 22:54
@mmalerba
Copy link
Contributor Author

feedback addressed

crisbeto
crisbeto approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I must have missed the notification. LGTM, but there's a lint check failure.

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Nov 10, 2020
jelbourn
jelbourn approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw merged commit 6612167 into angular:master Nov 24, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @annieyw