Skip to content

feat(material/checkbox): Avoid nested divs in labels by changing to span instead. #20990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

feat(material/checkbox): Avoid nested divs in labels by changing to span instead. #20990

merged 1 commit into from
Nov 13, 2020

Conversation

jesscxu
Copy link
Contributor

@jesscxu jesscxu commented Nov 9, 2020

What:
Change <div> to <span>

Why:
<div> elements should not be nested inside <label> elements because <label> only allows phrasing content

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2020
@jesscxu jesscxu force-pushed the update-span-to-div-nested-labels-checkbox branch from 5b9adfa to 716ba7e Compare November 10, 2020 20:50
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 12, 2020
mmalerba
mmalerba approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 94bd0d4 into angular:master Nov 13, 2020
mmalerba pushed a commit that referenced this pull request Nov 13, 2020
@jesscxu @mmalerba
feat(material/checkbox): Avoid nested divs in labels by changing to s…
c7153e1 
…pan instead. (#20990)

Co-authored-by: Jessica Xu <jessicacxu@google.com>
(cherry picked from commit 94bd0d4)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 5, 2020
@crisbeto
fix(material/slide-toggle): remove divs nested inside label
911eda4 
We made similar adjustments to other components that had `div`
elements inside the control `label` (angular#20990, angular#20986), but we never
fixed it for the slide toggle.
@crisbeto crisbeto mentioned this pull request Dec 5, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesscxu @mmalerba