Skip to content

docs(material/dialog): add a11y section about manual focus restoration #21011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

docs(material/dialog): add a11y section about manual focus restoration #21011

merged 1 commit into from
Nov 13, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Nov 11, 2020 •
edited
Loading

Addresses #17962 by adding a viable workaround in the docs since currently there is no good way to fix it without it being very complicated.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2020
@annieyw annieyw force-pushed the dialog-docs branch 3 times, most recently from 2dfa238 to 71a2093 Compare November 11, 2020 00:55
@annieyw annieyw added docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 11, 2020
@annieyw annieyw removed the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 11, 2020
@annieyw annieyw requested review from jelbourn and mmalerba November 11, 2020 01:02
@annieyw annieyw marked this pull request as ready for review November 11, 2020 01:02
crisbeto
crisbeto approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits.

jelbourn
jelbourn reviewed Nov 12, 2020
View reviewed changes
mmalerba
mmalerba approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like it needs a rebase for CI to be happy though

@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Nov 12, 2020
@mmalerba mmalerba merged commit 9f641d1 into angular:master Nov 13, 2020
mmalerba pushed a commit that referenced this pull request Nov 13, 2020
@annieyw @mmalerba
docs(material/dialog): add a11y section about manual focus restoration (
117637c 
#21011)

(cherry picked from commit 9f641d1)
@jelbourn jelbourn mentioned this pull request Nov 24, 2020
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2020
@annieyw annieyw deleted the dialog-docs branch December 29, 2020 06:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annieyw @jelbourn @crisbeto @mmalerba