Skip to content

fix(material/tabs): background color inherited to nested groups #21533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

fix(material/tabs): background color inherited to nested groups #21533

merged 1 commit into from
Jan 15, 2021

Conversation

crisbeto
Copy link
Member

Fixes that setting a backgroundColor on a top-level tab group ends up being inherited to all grounds nested within it. The problem was that our selectors were too broad and they were targeting all descendants.

Fixes #14819.
Fixes #21530.

@crisbeto
fix(material/tabs): background color inherited to nested groups
7b0fac8 
Fixes that setting a `backgroundColor` on a top-level tab group ends up being inherited
to all grounds nested within it. The problem was that our selectors were too broad and
they were targeting all descendants.

Fixes angular#14819.
Fixes angular#21530.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 10, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 10, 2021
This was referenced Jan 10, 2021
Closed
Closed
Closed
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 10, 2021
@crisbeto
Copy link
Member Author

Caretaker note: these selectors are somewhat fragile so it's possible that I've broken something, even though I've tried to cover everything. Let me know if there are any screenshot failures and I can check everything again.

Splaktar
Splaktar approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2021
@mmalerba mmalerba merged commit bf0dff8 into angular:master Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@crisbeto @mmalerba
fix(material/tabs): background color inherited to nested groups (#21533)
e40902d 
Fixes that setting a `backgroundColor` on a top-level tab group ends up being inherited
to all grounds nested within it. The problem was that our selectors were too broad and
they were targeting all descendants.

Fixes #14819.
Fixes #21530.

(cherry picked from commit bf0dff8)
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@crisbeto @mmalerba
fix(material/tabs): background color inherited to nested groups (#21533)
934f7eb 
Fixes that setting a `backgroundColor` on a top-level tab group ends up being inherited
to all grounds nested within it. The problem was that our selectors were too broad and
they were targeting all descendants.

Fixes #14819.
Fixes #21530.

(cherry picked from commit bf0dff8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
4 participants
@crisbeto @Splaktar @mmalerba @andrewseguin