Skip to content

Conversation

wagnermaciel
Copy link
Contributor

  • add method stubs for MDCSliderAdapter implementation
  • add basic setup for MDCSliderFoundation in MatSlider

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2021
@wagnermaciel wagnermaciel changed the title feat(material-experimental/mdc-slider): add skeleton code for MatSlider feat(material-experimental/mdc-slider): add skeleton code for MDCSliderFoundation Jan 20, 2021
@wagnermaciel wagnermaciel marked this pull request as ready for review January 20, 2021 18:08
@wagnermaciel wagnermaciel added target: feature This PR is targeted for a feature branch (outside of main and semver branches) merge safe labels Jan 20, 2021
@wagnermaciel
Copy link
Contributor Author

@jelbourn Made those changes. I'll squash the commits before I submit the PR.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jan 20, 2021
MatSliderAdapter

* create slider-adapter.ts
* add method stubs for MDCSliderAdapter implementation
* add MDCSliderFoundation class variable to MatSlider
@wagnermaciel wagnermaciel merged commit 8a7a57e into angular:mdc-slider Jan 20, 2021
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Feb 17, 2021
…r#21645)

MatSliderAdapter

* create slider-adapter.ts
* add method stubs for MDCSliderAdapter implementation
* add MDCSliderFoundation class variable to MatSlider
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Feb 17, 2021
…erAdapter (angular#21645)

* create slider-adapter.ts
* add method stubs for MDCSliderAdapter implementation
* add MDCSliderFoundation class variable to MatSlider
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants