Skip to content

feat(material-experimental/mdc-slider): add skeleton code for MatSlid… #21655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

wagnermaciel
Copy link
Contributor

…erThumb

  • created slider-thumb.ts
  • created MatSliderThumb directive for the mdc-slider input

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2021
@wagnermaciel wagnermaciel force-pushed the slider-thumb-skeleton branch 2 times, most recently from fb2631d to b59fa42 Compare January 20, 2021 23:43
@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jan 20, 2021
@wagnermaciel wagnermaciel force-pushed the slider-thumb-skeleton branch from f846a9e to 6b8f7d3 Compare January 20, 2021 23:48
@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 20, 2021
@angular angular deleted a comment from google-cla bot Jan 20, 2021
@angular angular deleted a comment from google-cla bot Jan 20, 2021
@wagnermaciel wagnermaciel force-pushed the slider-thumb-skeleton branch from 6b8f7d3 to c0850d4 Compare January 21, 2021 00:05
@wagnermaciel wagnermaciel marked this pull request as ready for review January 21, 2021 00:22
@wagnermaciel wagnermaciel added merge safe target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Jan 21, 2021
@wagnermaciel
Copy link
Contributor Author

@crisbeto I made those changes 👍🏽

@wagnermaciel wagnermaciel requested a review from crisbeto January 21, 2021 17:00
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…erThumb

* created slider-thumb.ts
* created MatSliderThumb directive for the mdc-slider input
@wagnermaciel wagnermaciel force-pushed the slider-thumb-skeleton branch from b9fb1a0 to 003740f Compare January 21, 2021 17:02
@wagnermaciel wagnermaciel merged commit 25193ca into angular:mdc-slider Jan 21, 2021
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Feb 17, 2021
…erThumb (angular#21655)

* created slider-thumb.ts
* created MatSliderThumb directive for the mdc-slider input
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Feb 17, 2021
…erThumb (angular#21655)

* created slider-thumb.ts
* created MatSliderThumb directive for the mdc-slider input
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants