Skip to content

build: run example harness unit tests and fix errors #21759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

build: run example harness unit tests and fix errors #21759

merged 1 commit into from
Feb 1, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 31, 2021 •
edited
Loading

  • Makes it so we're able to run the test harness example tests to make sure they actually work.
  • Fixes several example unit tests that didn't pass.
  • Reduces the boilerplate in the example tests.

Fixes #21758.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 31, 2021
@crisbeto crisbeto force-pushed the harness-test-examples-check branch from 5ab4051 to a9d3159 Compare January 31, 2021 14:16
@crisbeto crisbeto changed the title build: run test harness example tests build: run example harness unit tests and fix errors Jan 31, 2021
crisbeto
crisbeto commented Jan 31, 2021
View reviewed changes
tools/defaults.bzl
deps = [
"//test:angular_test_init",
] + deps,
deps = deps if exclude_init_script else ["//test:angular_test_init"] + deps,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is necessary so that the test setup is identical between the local environment and Stackblitz.

@crisbeto
build: run example harness unit tests and fix errors
a5125c7 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
@crisbeto crisbeto force-pushed the harness-test-examples-check branch from a9d3159 to a5125c7 Compare January 31, 2021 14:28
@crisbeto crisbeto marked this pull request as ready for review January 31, 2021 14:50
@crisbeto crisbeto requested review from andrewseguin and a team as code owners January 31, 2021 14:50
@crisbeto crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jan 31, 2021
@crisbeto crisbeto mentioned this pull request Jan 31, 2021
Closed
annieyw
annieyw approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@annieyw annieyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix. I think I tried most of the examples manually in stackblitz when I sent out the PRs initially but must've missed some. Its much better to be able to actually run them.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 1, 2021
@wagnermaciel wagnermaciel merged commit 6947a39 into angular:master Feb 1, 2021
wagnermaciel pushed a commit that referenced this pull request Feb 1, 2021
@crisbeto @wagnermaciel
build: run example harness unit tests and fix errors (#21759)
c87506e 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes #21758.

(cherry picked from commit 6947a39)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
build: run example harness unit tests and fix errors (angular#21759)
b31580d 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
build: run example harness unit tests and fix errors (angular#21759)
8093038 
* Makes it so we're able to run the test harness example tests to make sure they pass.
* Fixes several example unit tests that didn't pass.
* Reduces the boilerplate in the example tests.

Fixes angular#21758.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

1 more reviewer

@annieyw annieyw annieyw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jelbourn jelbourn

@josephperrott josephperrott

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatDialogHarness ): tests from the docs fail
5 participants
@crisbeto @annieyw @jelbourn @josephperrott @wagnermaciel