fix(cdk/drag-drop): destroyed items not being cleaned up correctly #21821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a memory leak in `CdkDrag` which prevented it from being cleaned up. The problem is that we keep track of all the instances in an array, but there was a typo in the cleanup logic which meant that the items would never be removed from the array. Fixes angular#21818.
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Feb 12, 2021
…21821) Fixes a memory leak in `CdkDrag` which prevented it from being cleaned up. The problem is that we keep track of all the instances in an array, but there was a typo in the cleanup logic which meant that the items would never be removed from the array. Fixes #21818. (cherry picked from commit 52aa210)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in
CdkDragwhich prevented it from being cleaned up. The problem is that we keep track of all the instances in an array, but there was a typo in the cleanup logic which meant that the items would never be removed from the array.Fixes #21818.