Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 7, 2021

Adds a wrapper around the Google Maps Geocoder API. Also exports MapDirectionsResponse which wasn't exposed in a previous PR.

Fixes #21665.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Feb 7, 2021
@crisbeto crisbeto requested a review from a team as a code owner February 7, 2021 13:34
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2021
Copy link
Collaborator

@mbehrlich mbehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Adds a wrapper around the Google Maps Geocoder API.
Also exports `MapDirectionsResponse` which wasn't exposed in a previous PR.

Fixes angular#21665.
@crisbeto crisbeto force-pushed the 21665/google-maps-geocoder branch from 4945ab3 to d51340a Compare February 8, 2021 19:52
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2021
@mmalerba mmalerba merged commit 86251af into angular:master Feb 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(google-maps): geocoder wrapper
3 participants