docs: implement ControlValueAccessor in the code snippet #21905
Conversation
`this` should implement `ControlValueAccessor` because `valueAccessor` has type `ControlValueAccessor | null` in the `this.ngControl.valueAccessor = this;`
google-cla
bot
added
the
cla: yes
| @@ -202,7 +202,7 @@ To resolve this, remove the `NG_VALUE_ACCESSOR` provider and instead set the val | |||
| // }, | |||
| ], | |||
| }) | |||
| export class MyTelInput implements MatFormFieldControl<MyTel> { | |||
| export class MyTelInput implements MatFormFieldControl<MyTel>, ControlValueAccessor { | |||
There was a problem hiding this comment.
There are some more snippets like this one after the ngControl section. Should it be added there as well?
There was a problem hiding this comment.
I've found only one snippet after the ngControl section. It's improving-accessibility.
Probably, there's no need to add ControlValueAccessor there becasue forms are not main subject of that section.
There was a problem hiding this comment.
I guess the way I've been reading the guide is that the sections build on top of each other so it would be weird if one snippet had it and the other one didn't.
There was a problem hiding this comment.
I've reread the docs and found very important point in the errorState section:
Since we're not using an NgControl in this example, we don't need to do anything ...
So I think there's no need to add ControlValueAccessor in other sections except ngControl
What do you think?
crisbeto
added
docs
`this` should implement `ControlValueAccessor` because `valueAccessor` has type `ControlValueAccessor | null` in the `this.ngControl.valueAccessor = this;` (cherry picked from commit 8726e57)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
thisshould implementControlValueAccessorbecausevalueAccessorhas typeControlValueAccessor | nullin the
this.ngControl.valueAccessor = this;(line 216)Affected URL: https://material.angular.io/guide/creating-a-custom-form-field-control#ngcontrol