fix(material/tabs): avoid interrupting click event when scrolling the header #21911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
… header When a header is scrollable, we scroll a tab into view whenever it receives focus. The problem is that if focus is moved as a result of a mouse/touch event, the tab can be moved out from under the pointer, interrupting the click. These changes work around the issue by not scrolling the header on mouse/touch focus. Fixes angular#21898.
crisbeto
force-pushed
the
21898/tabs-click-interrupt
branch
from
1004531 to
79757e4
Compare
andrewseguin
approved these changes
Jul 21, 2021
mmalerba
pushed a commit
that referenced
this pull request
Jul 27, 2021
… header (#21911) When a header is scrollable, we scroll a tab into view whenever it receives focus. The problem is that if focus is moved as a result of a mouse/touch event, the tab can be moved out from under the pointer, interrupting the click. These changes work around the issue by not scrolling the header on mouse/touch focus. Fixes #21898. (cherry picked from commit 4279ff1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a header is scrollable, we scroll a tab into view whenever it receives focus. The problem is that if focus is moved as a result of a mouse/touch event, the tab can be moved out from under the pointer, interrupting the click.
These changes work around the issue by not scrolling the header on mouse/touch focus.
Fixes #21898.