Skip to content

refactor(material/theming): normalize config in all typography mixins for non-mdc components #21937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

refactor(material/theming): normalize config in all typography mixins for non-mdc components #21937

merged 1 commit into from
Feb 24, 2021

Conversation

mmalerba
Copy link
Contributor

This is split off of #21778 which covers MDC conmponents as well

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 17, 2021
crisbeto
crisbeto approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI is failing.

@mmalerba mmalerba force-pushed the typog-norm-non-mdc branch 2 times, most recently from f99b9ee to bf207b1 Compare February 18, 2021 22:14
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 18, 2021
jelbourn
jelbourn approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 18, 2021
@andrewseguin
Copy link
Contributor

Needs rebase

@mmalerba
refactor(material/theming): normalize config in all typography mixins
a8b2cef 
for non-mdc components

This is split off of angular#21778 which covers MDC conmponents as well
@mmalerba
Copy link
Contributor Author

@andrewseguin rebased

@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 24, 2021
@andrewseguin andrewseguin merged commit c34511e into angular:master Feb 24, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @andrewseguin @jelbourn @crisbeto