test(material/select): remove form-field dependency in deselection test #21963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Feb 20, 2021
The existing test would not work without using mat-form-field wrapper because the trigger.click() propagates to onContainerClick of FormField which calls select.open() a second time. With this change, the logic does not base on propagating/onContainerClick but on specific open and close commands of the panel.
jeripeierSBB
force-pushed
the
patch-4
branch
from
c9459e9 to
1d4fa62
Compare
crisbeto
added
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Feb 23, 2021
…st (#21963) The existing test would not work without using mat-form-field wrapper because the trigger.click() propagates to onContainerClick of FormField which calls select.open() a second time. With this change, the logic does not base on propagating/onContainerClick but on specific open and close commands of the panel. (cherry picked from commit dd4a171)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test would not work without using mat-form-field wrapper because the trigger.click() propagates to onContainerClick of FormField which calls select.open() a second time.
With this change, the logic does not base on propagating/onContainerClick but on specific open and close commands of the panel.