Skip to content

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2021
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for jelbourn February 25, 2021 17:35
* put NG_VALUE_ACCESSOR provider definition inline
* fix _onTouched type definition
* implement setDisabledState
@wagnermaciel wagnermaciel removed the request for review from devversion February 25, 2021 17:48
* delete unused 'forwardRef' from imports
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* change #setDisabledState implementation so that if either input gets disabled, the whole slider gets disabled
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Mar 1, 2021
@wagnermaciel wagnermaciel merged commit d6d8760 into angular:mdc-slider Mar 1, 2021
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 4, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 5, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 5, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 11, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 11, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 12, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 23, 2021
…sor (angular#22016)

* feat(material-experimental/mdc-slider): implement control value accessor
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants