Skip to content

Conversation

mmalerba
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2021
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Feb 25, 2021
Copy link
Contributor

@annieyw annieyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think you also need to fix the spelling in the mdc-tooltip test (failing lint check)

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 25, 2021
@wagnermaciel
Copy link
Contributor

wagnermaciel commented Feb 26, 2021

@mmalerba There's a single test in g3 that's failing because TOOLTIP_PANEL_CLASS changed from 'mat-tooltip-panel' to just 'tooltip-panel'. I see that for our code we changed things to now use ${this._cssClassPrefix}-${TOOLTIP_PANEL_CLASS}, but given that it's only one test failing, would it be ok to just change it to the hardcoded string '.mat-tooltip-panel'?

Also, won't we also need to update the docs for this, since we're changing TOOLTIP_PANEL_CLASS?
https://material.angular.io/components/tooltip/api#TOOLTIP_PANEL_CLASS

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
Copy link
Contributor Author

@wagnermaciel updated to not change that constant and just deprecate it for later removal

@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 2, 2021
@wagnermaciel wagnermaciel merged commit 7161587 into angular:master Mar 2, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants