build: add test to ensure compatibility with ng-linker #22351

devversion · 2021-03-26T18:48:43Z

Creates a CI job to ensure compatibility with the ng-linker.

devversion · 2021-04-15T18:47:23Z

This will be unblocked with angular/angular#41583

devversion · 2021-04-28T16:26:07Z

This is now unblocked and ready for review. cc. @jelbourn @josephperrott

josephperrott

LGTM

Though I am not the right person to confirm this is the correct/best way to test the ng-linker.

integration/runfile-helpers.js

jelbourn

Overall LGTM, you can add merge ready when ready

cc @petebacondarwin just FYI

integration/BUILD.bazel

integration/linker/BUILD.bazel

integration/linker/link-packages-test.js

integration/runfile-helpers.js

petebacondarwin

I have some views on some of the naming, which you might like to consider.

I note that this only tests that the partial declarations were processed without error, right? Are there plans to run some e2e tests, or similar, on the resulting linked code?

integration/linker/link-packages-test.js

tools/BUILD.bazel

.circleci/config.yml

integration/linker/link-packages-test.js

devversion · 2021-04-30T09:36:42Z

@petebacondarwin I initially considered running e2e tests with the linker, but thought it would be quite tricky/require a lot of refactoring to get that running with our Bazel setup.

I've spent more time on this, and got the e2e tests working with partial compilation enabled.

@petebacondarwin @jelbourn @josephperrott Please have a look at the second commit.

jelbourn

LGTM

petebacondarwin

LGTM2

petebacondarwin · 2021-04-30T17:16:43Z

src/e2e-app/BUILD.bazel

 load("@npm//@bazel/concatjs:index.bzl", "concatjs_devserver")
 load("//:packages.bzl", "getAngularUmdTargets")
 load("//tools:defaults.bzl", "ng_module", "sass_binary")

 package(default_visibility = ["//visibility:public"])

+# List of dependencies that are referenced in the `index.html` file.
+devserverIndexHtmlDependencies = [


I read this as devversionIndexHtmlDependencies and thought, why...? 😆

src/e2e-app/BUILD.bazel

petebacondarwin · 2021-04-30T17:19:32Z

src/e2e-app/rollup-with-linker.config.js

+ * which are not statically analyzable. We work around this by transforming the
+ * dynamic non-static imports to statically analyzable dynamic imports that can be
+ * processed by rollup. e.g. "import(`@angular/components-examples/${module}/index.js`")
+ * will be transformed into an object that merges exports from all possible `${module}` values.


It might be worth noting for the future, that if you have @angular/compiler loaded at runtime, then partial declarations can be JIT compiled to full definitions, without the need for the linker...

I see. good to know! I'm not sure what's best here; but I imagine the JIT compilation slowing down tests a little bit more (if not significantly)

tools/postinstall/apply-patches.js

josephperrott

LGTM

mmalerba · 2021-05-13T16:42:07Z

@devversion needs rebase

Adds tests to ensure that Angular components is compatible with Angular's patial compilation mode and the linker. A new job running every hour ensures that changes to the partial compilation or linker in Angular `master` are compatible with the components repository. Additionally, we add a job that runs for each commit/PR in order to insure that Angular components remains compatible with the linker of already-released Angular versions.

Address feedback

devversion · 2021-05-13T18:04:19Z

@mmalerba Done 👍

* build: add tests to ensure compatibility with ng-linker Adds tests to ensure that Angular components is compatible with Angular's patial compilation mode and the linker. A new job running every hour ensures that changes to the partial compilation or linker in Angular `master` are compatible with the components repository. Additionally, we add a job that runs for each commit/PR in order to insure that Angular components remains compatible with the linker of already-released Angular versions. * build: build and run e2e tests in partial compilation mode * fixup! build: build and run e2e tests in partial compilation mode Address feedback (cherry picked from commit 7d53a6d)

angular-automatic-lock-bot · 2021-06-17T00:01:47Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 26, 2021

devversion added the in progress This issue is currently in progress label Mar 26, 2021

devversion assigned josephperrott Mar 26, 2021

devversion added the area: build & ci Related the build and CI infrastructure of the project label Mar 26, 2021

devversion mentioned this pull request Mar 29, 2021

feat(bazel): allow setting compilationMode in ng_module rule angular/angular#41366

Closed

devversion mentioned this pull request Apr 1, 2021

feat(bazel): allow setting compilationMode in ng_module rule [patch port] angular/angular#41418

Closed

devversion force-pushed the build/add-angular-linker-compability-test branch from 94deda9 to 3c3b1b1 Compare April 7, 2021 19:13

devversion force-pushed the build/add-angular-linker-compability-test branch 3 times, most recently from 8b9186b to 51606a3 Compare April 21, 2021 20:37

devversion mentioned this pull request Apr 21, 2021

build: update to angular v12.0.0-rc.0 #22534

Merged

devversion force-pushed the build/add-angular-linker-compability-test branch from 51606a3 to 0e47338 Compare April 27, 2021 17:19

devversion marked this pull request as ready for review April 27, 2021 20:13

devversion requested review from jelbourn and a team as code owners April 27, 2021 20:13

devversion requested a review from josephperrott April 27, 2021 20:14

devversion added target: rc This PR is targeted for the next release-candidate and removed in progress This issue is currently in progress labels Apr 27, 2021

devversion assigned jelbourn Apr 28, 2021

josephperrott approved these changes Apr 28, 2021

View reviewed changes

integration/runfile-helpers.js Outdated Show resolved Hide resolved

devversion force-pushed the build/add-angular-linker-compability-test branch from 0e47338 to ec3b651 Compare April 28, 2021 20:22

jelbourn approved these changes Apr 29, 2021

View reviewed changes

petebacondarwin reviewed Apr 29, 2021

View reviewed changes

integration/linker/link-packages-test.js Outdated Show resolved Hide resolved

tools/BUILD.bazel Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

integration/linker/link-packages-test.js Show resolved Hide resolved

devversion force-pushed the build/add-angular-linker-compability-test branch 2 times, most recently from 87b2a7a to 313e905 Compare April 29, 2021 20:01

devversion requested a review from andrewseguin as a code owner April 29, 2021 20:01

devversion force-pushed the build/add-angular-linker-compability-test branch 5 times, most recently from 5ff4a07 to dae982c Compare April 30, 2021 08:34

devversion requested review from jelbourn, josephperrott and petebacondarwin April 30, 2021 09:37

jelbourn approved these changes Apr 30, 2021

View reviewed changes

petebacondarwin approved these changes Apr 30, 2021

View reviewed changes

devversion added the action: merge The PR is ready for merge by the caretaker label Apr 30, 2021

josephperrott approved these changes Apr 30, 2021

View reviewed changes

devversion added the P2 The issue is important to a large percentage of users, with a workaround label May 3, 2021

devversion force-pushed the build/add-angular-linker-compability-test branch from 1b7db3f to 187d28a Compare May 3, 2021 18:26

devversion force-pushed the build/add-angular-linker-compability-test branch from 187d28a to 83f9628 Compare May 11, 2021 20:27

devversion added the merge safe label May 12, 2021

mmalerba added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 13, 2021

devversion added 3 commits May 13, 2021 19:54

build: build and run e2e tests in partial compilation mode

5875bca

fixup! build: build and run e2e tests in partial compilation mode

b020b3e

Address feedback

devversion force-pushed the build/add-angular-linker-compability-test branch from 83f9628 to b020b3e Compare May 13, 2021 17:56

andrewseguin merged commit 7d53a6d into angular:master May 17, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2021

build: add test to ensure compatibility with ng-linker #22351

build: add test to ensure compatibility with ng-linker #22351

Uh oh!

Conversation

devversion commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devversion commented Apr 15, 2021

Uh oh!

devversion commented Apr 28, 2021

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devversion commented Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

petebacondarwin Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

devversion Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

mmalerba commented May 13, 2021

Uh oh!

devversion commented May 13, 2021

Uh oh!

angular-automatic-lock-bot bot commented Jun 17, 2021

Uh oh!

Uh oh!

devversion commented Mar 26, 2021 •

edited

Loading

devversion commented Apr 30, 2021 •

edited

Loading