build: don't require all reviewers to approve PRs #22363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting has been causing friction on PRs, requiring reviewers to be manually approved. The "merge ready" label should only be applied once a PR is approved.
jelbourn
added
P2
google-cla
bot
added
the
cla: yes
annieyw
pushed a commit
that referenced
this pull request
Apr 1, 2021
This setting has been causing friction on PRs, requiring reviewers to be manually approved. The "merge ready" label should only be applied once a PR is approved. (cherry picked from commit 48e22f3)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting has been causing friction on PRs, requiring reviewers to be
manually approved. The "merge ready" label should only be applied once
a PR is approved.
@josephperrott similar to the discussion the framework team had last week, people are running into friction with applying "merge ready" as a type of auto-submit. This PR disables the setting for requiring all reviewers; we want to keep the "merge ready" label explicitly as meaning approved and ready to be merged, not that the PR will be ready to merge after review.