Skip to content

fix(material/list): dispatching model change event multiple times in single selection mode #22376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

fix(material/list): dispatching model change event multiple times in single selection mode #22376

merged 1 commit into from
Apr 13, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the MDC-based list dispatches its ngModelChange event multiple times when the value changes in single selection mode.

Fixes #22276.

@crisbeto
fix(material/list): dispatching model change event multiple times in …
d3dc31c 
…single selection mode

Fixes that the MDC-based list dispatches its `ngModelChange` event multiple times when the value changes in single selection mode.

Fixes angular#22276.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 31, 2021
@crisbeto crisbeto requested a review from mmalerba March 31, 2021 12:52
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 31, 2021
jelbourn
jelbourn approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 9, 2021
@mmalerba mmalerba merged commit 7702177 into angular:master Apr 13, 2021
mmalerba pushed a commit that referenced this pull request Apr 13, 2021
@crisbeto @mmalerba
fix(material/list): dispatching model change event multiple times in …
11ff7ba 
…single selection mode (#22376)

Fixes that the MDC-based list dispatches its `ngModelChange` event multiple times when the value changes in single selection mode.

Fixes #22276.

(cherry picked from commit 7702177)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-selection-list): Model change fired twice for the selection list with [multiple]="false"
3 participants
@crisbeto @jelbourn @mmalerba