refactor(material/core): clean up prefixes from internal Sass symbols #22378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
andrewseguin
approved these changes
Mar 31, 2021
|
LGTM - feel free to add |
crisbeto
force-pushed
the
sass-private-cleanup
branch
from
1c4f90f to
e3729ed
Compare
crisbeto
force-pushed
the
sass-private-cleanup
branch
from
e3729ed to
729d0fe
Compare
|
I'm seeing a bunch of screenshots that seem to show the form-field label not floating anymore, instead overlapping the value |
The Sass migration script doesn't migrate private symbols (starting with `_`) so we were left with some prefixes. These changes clean up the prefixes, as well as some unnecessary `!global` declarations.
crisbeto
force-pushed
the
sass-private-cleanup
branch
from
729d0fe to
448b8a2
Compare
|
Reverted the changes that could've broken the floating label. They were nice-to-haves anyway. |
crisbeto
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sass migration script doesn't migrate private symbols (starting with
_) so we were left with some prefixes. These changes clean up the prefixes, as well as some unnecessary!globaldeclarations.