Skip to content

build: add check for new theming bundle #22398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

build: add check for new theming bundle #22398

merged 1 commit into from
Apr 6, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 4, 2021

Sets up a build check to verify that the new theming API works.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: major This PR is targeted for the next major release labels Apr 4, 2021
@crisbeto crisbeto requested a review from devversion April 4, 2021 16:53
@crisbeto crisbeto requested a review from jelbourn as a code owner April 4, 2021 16:53
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2021
devversion
devversion approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small nit

@crisbeto
build: add check for new theming bundle
d28e998 
Sets up a build check to verify that the new theming API works.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 5, 2021
@annieyw annieyw merged commit d93c85c into angular:master Apr 6, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @devversion @annieyw