Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 5, 2021

As discussed, adds a new multiple scope for commits that cover more than one area.

As discussed, adds a new `multiple` scope for commits that cover more than one area.
@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Apr 5, 2021
@crisbeto crisbeto requested a review from jelbourn April 5, 2021 13:43
@crisbeto crisbeto requested a review from a team as a code owner April 5, 2021 13:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2021
@josephperrott
Copy link
Member

I will leave it to you all since this repository does not rely on the commit messages from a PR to create commit message. My personal perspective is that if a change needs to affect multiple areas, it should be split into multiple specific commits. Since these commits are used to generate our release notes, it is best for us to have specific targeted scopes for our commits so that changes appear as best as possible in our release notes.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it makes sense to have this when a refactoring would be too cumbersome to have per-component commits (e.g., making all @Output members readonly)

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 7, 2021
@devversion
Copy link
Member

Just FYI: We updated the dev-infra code to accept refactor and test commits without scope. angular/angular@f98f379.

I can still see multiple being useful for other commit types.

@mmalerba mmalerba merged commit 70564f3 into angular:master Apr 8, 2021
mmalerba pushed a commit that referenced this pull request Apr 8, 2021
As discussed, adds a new `multiple` scope for commits that cover more than one area.

(cherry picked from commit 70564f3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants