build: only run snapshot tests against main branch #22424
Merged
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
main-branch-snapshots
branch
2 times, most recently
from
0c5d398 to
304537b
Compare
crisbeto
commented
Apr 7, 2021
.circleci/config.yml
Outdated
| - view_engine_snapshot_test_cronjob | ||
| - mdc_snapshot_test_cronjob | ||
| - snapshot_tests_local_browsers: | ||
| filters: *only_main_branch_filter |
There was a problem hiding this comment.
Disclaimer: I don't actually know if this will work as expected, I'm basing it on how we've dealt with similar situations in other places. As far as I can tell, there's no good way of testing it without merging in the changes.
There was a problem hiding this comment.
I tried parsing the config and it looks like this needs to be indented as above with other jobs using filters.
crisbeto
force-pushed
the
main-branch-snapshots
branch
from
304537b to
1d5d038
Compare
Limits the various snapshot tests to only run against the main branch. They are very likely to main against the older branches, because by definition Angular's latest changes at HEAD might not be backwards-compatible.
crisbeto
force-pushed
the
main-branch-snapshots
branch
from
1d5d038 to
637fd6b
Compare
devversion
approved these changes
Apr 7, 2021
mmalerba
pushed a commit
that referenced
this pull request
Apr 8, 2021
Limits the various snapshot tests to only run against the main branch. They are very likely to main against the older branches, because by definition Angular's latest changes at HEAD might not be backwards-compatible. (cherry picked from commit 5f00365)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the various snapshot tests to only run against the main branch. They are very likely to fail against the older branches, because by definition Angular's latest changes at HEAD might not be backwards-compatible.