Skip to content

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Apr 16, 2021

  • update configurable example to
    • have useful labels and use aria-labelledby
    • have labels that work in horizontal and vertical modes
  • add aria-label to other examples
  • add step to formatting example

Fixes #7933

Images of new labels

This layout was inspired by the example in the spec: https://material.io/components/sliders#theming.

Screen Shot 2021-04-15 at 20 50 21
Screen Shot 2021-04-15 at 20 50 46
Screen Shot 2021-04-15 at 20 51 16

Previous screen reader output

  1. 0 , slider
  2. 1 , slider
  3. 50 , slider
  4. 0 , slider

New screen reader output

  1. 0 , Max Value, slider
  2. 0 , units, slider
  3. 50 , unit(s), slider
  4. 0 , unit(s), slider

@Splaktar Splaktar added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: material/slider labels Apr 16, 2021
@Splaktar Splaktar requested a review from annieyw April 16, 2021 01:09
@Splaktar Splaktar self-assigned this Apr 16, 2021
@Splaktar Splaktar requested a review from andrewseguin as a code owner April 16, 2021 01:09
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 16, 2021
- update configurable example to
  - have useful labels and use `aria-labelledby`
  - have labels that work in horizontal and vertical modes
- add `aria-label` to other examples
- add `step` to formatting example

Fixes angular#7933
@Splaktar Splaktar force-pushed the slider-example-a11y branch from a2d5c77 to 2be78c5 Compare April 16, 2021 01:16
@Splaktar Splaktar added the target: patch This PR is targeted for the next patch release label Apr 16, 2021
@annieyw annieyw added action: merge The PR is ready for merge by the caretaker merge safe labels Apr 16, 2021
@wagnermaciel wagnermaciel merged commit a0a77d7 into angular:master Apr 19, 2021
wagnermaciel pushed a commit that referenced this pull request Apr 19, 2021
- update configurable example to
  - have useful labels and use `aria-labelledby`
  - have labels that work in horizontal and vertical modes
- add `aria-label` to other examples
- add `step` to formatting example

Fixes #7933

(cherry picked from commit a0a77d7)
wagnermaciel pushed a commit that referenced this pull request Apr 19, 2021
- update configurable example to
  - have useful labels and use `aria-labelledby`
  - have labels that work in horizontal and vertical modes
- add `aria-label` to other examples
- add `step` to formatting example

Fixes #7933

(cherry picked from commit a0a77d7)
@Splaktar Splaktar deleted the slider-example-a11y branch April 20, 2021 00:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/slider cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider example is missing an aria-label

3 participants