Skip to content

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Apr 16, 2021

…pdate examples

Some of the snack bar examples had both an action and a duration which is not accessible.

"Dismiss" actions are not actually discouraged in the specs
https://material.io/components/snackbars#usage

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation labels Apr 16, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 16, 2021
@annieyw annieyw added merge safe target: patch This PR is targeted for the next patch release labels Apr 16, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 17, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit 16d57ae into angular:master Apr 21, 2021
wagnermaciel pushed a commit that referenced this pull request Apr 21, 2021
wagnermaciel pushed a commit that referenced this pull request Apr 21, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants