Skip to content

Conversation

crisbeto
Copy link
Member

Fixes a few places that will become compilation errors in rxjs version 7. All of the changes are backwards-compatible so we can merge them now so that we have less issues to resolve once we make the switch.

Note: I'm marking this as merge safe, because all of the changes are internal and they only affect type information. There are a couple of extra null checks, but they're in cdk-experimental which is also merge safe.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: rc This PR is targeted for the next release-candidate labels Apr 26, 2021
@crisbeto crisbeto requested a review from jelbourn April 26, 2021 12:19
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 26, 2021
@crisbeto crisbeto force-pushed the rxjs7-pre-cleanup branch from 9c18520 to bf1c5ca Compare April 26, 2021 12:39
Fixes a few places that will become compilation errors in rxjs version 7. All of the changes are backwards-compatible so we can merge them now so that we have less issues to resolve once we make the switch.
@crisbeto crisbeto force-pushed the rxjs7-pre-cleanup branch from bf1c5ca to 9ee0816 Compare April 26, 2021 12:43
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 26, 2021
@jelbourn
Copy link
Member

jelbourn commented Apr 26, 2021

I have to be a wet blanket and remove merge safe because this does touch sources used in Google. Even though the types should be internal only, they still might break due to stuff like different build setup, rxjs local mods, etc.

@andrewseguin andrewseguin merged commit dda2e0f into angular:master Apr 27, 2021
andrewseguin pushed a commit that referenced this pull request Apr 27, 2021
Fixes a few places that will become compilation errors in rxjs version 7. All of the changes are backwards-compatible so we can merge them now so that we have less issues to resolve once we make the switch.

(cherry picked from commit dda2e0f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants