build: update to rules_nodejs v3.5.0 #22693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the latest version of `rules_nodejs` that contains various fixes for Windows. The linker has been preventing windows developers from running tests reliably. This has been fixed with: bazel-contrib/rules_nodejs@7cf7d73
google-cla
bot
added
the
cla: yes
devversion
added
merge safe
target: patch
devversion
added
action: merge
|
I'm adding P2 because this is merge safe and currently makes developing on Windows really difficult. |
andrewseguin
added
target: minor
andrewseguin
pushed a commit
that referenced
this pull request
May 19, 2021
Updates to the latest version of `rules_nodejs` that contains various fixes for Windows. The linker has been preventing windows developers from running tests reliably. This has been fixed with: bazel-contrib/rules_nodejs@7cf7d73
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest version of
rules_nodejsthat containsvarious fixes for Windows. The linker has been preventing windows
developers from running tests reliably. This has been fixed with:
bazel-contrib/rules_nodejs@7cf7d73