build: remove unnecessary postinstall rules_nodejs patch #22727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: patch
google-cla
bot
added
the
cla: yes
We recently updated to `rules_nodejs` 3.5.0. This contained a fix for something we recently tried to achieve using a postinstall patch. The PR that updated to 3.5.0 became a little out-of-date due to the PR introducing the postinstall patch being merged, so that the failure only surfaced when the update PR got merged.
devversion
force-pushed
the
build/fix-ci-postinstall-patc
branch
from
a98d7a5 to
4e22688
Compare
andrewseguin
approved these changes
May 19, 2021
andrewseguin
pushed a commit
that referenced
this pull request
May 19, 2021
We recently updated to `rules_nodejs` 3.5.0. This contained a fix for something we recently tried to achieve using a postinstall patch. The PR that updated to 3.5.0 became a little out-of-date due to the PR introducing the postinstall patch being merged, so that the failure only surfaced when the update PR got merged. (cherry picked from commit 9d87461)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated to
rules_nodejs3.5.0. This contained a fixfor something we recently tried to achieve using a postinstall
patch. The PR that updated to 3.5.0 became a little out-of-date
due to the PR introducing the postinstall patch being merged, so
that the failure only surfaced when the update PR got merged.