Skip to content

build: fix formatting for static properties and filter out coercion members #22823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

build: fix formatting for static properties and filter out coercion members #22823

merged 1 commit into from
May 27, 2021

Conversation

crisbeto
Copy link
Member

  • Fixes that there's no space between static and the property name.
  • Filters out the ngAcceptInputType_ properties from the docs.

Fixes #22816.

@crisbeto
build: fix formatting for static properties and filter out coercion m…
1f634c3 
…embers

* Fixes that there's no space between `static` and the property name.
* Filters out the `ngAcceptInputType_` properties from the docs.

Fixes angular#22816.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels May 27, 2021
@crisbeto crisbeto requested a review from devversion May 27, 2021 05:54
@crisbeto crisbeto requested a review from a team as a code owner May 27, 2021 05:54
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 27, 2021
devversion
devversion approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could have solved this with Nunjucks' whitespace control too, but I like this as it's more explicit.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label May 27, 2021
@mmalerba mmalerba merged commit fa616b9 into angular:master May 27, 2021
mmalerba pushed a commit that referenced this pull request May 27, 2021
@crisbeto @mmalerba
build: fix formatting for static properties and filter out coercion m…
0b66920 
…embers (#22823)

* Fixes that there's no space between `static` and the property name.
* Filters out the `ngAcceptInputType_` properties from the docs.

Fixes #22816.

(cherry picked from commit fa616b9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: static member marker is too close to the member name
3 participants
@crisbeto @devversion @mmalerba