Skip to content

build: remove outdated todo from bazel workspace file #22888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2021
Merged

build: remove outdated todo from bazel workspace file #22888

merged 1 commit into from
Jun 11, 2021

Conversation

devversion
Copy link
Member

We no longer use any browsers from rules_webtesting, so
the TODO in the WORKSPACE file is outdated. This commit
removes the comment.

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jun 4, 2021
@devversion devversion requested a review from a team as a code owner June 4, 2021 14:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2021
crisbeto
crisbeto approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2021
josephperrott
josephperrott approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin
Copy link
Contributor

Please rebase

@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Jun 11, 2021
@devversion
build: remove outdated todo from bazel workspace file
9ef3c8f 
We no longer use any browsers from `rules_webtesting`, so
the TODO in the `WORKSPACE` file is outdated. This commit
removes the comment.
@devversion devversion force-pushed the build/remove-stale-todo branch from 80eb51f to 9ef3c8f Compare June 11, 2021 12:53
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 11, 2021
@wagnermaciel wagnermaciel merged commit 9027d83 into angular:master Jun 11, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @andrewseguin @crisbeto @josephperrott @wagnermaciel