Skip to content

fix(multiple): add inject flags to manual injector calls #22922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix(multiple): add inject flags to manual injector calls #22922

merged 1 commit into from
Jun 10, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 8, 2021

Fixes a few more cases like #22665 where we were injecting something optionally, but we weren't passing the optional injector flag.

@crisbeto
fix(multiple): add inject flags to manual injector calls
7ec1535 
Fixes a few more cases like angular#22665 where we were injecting something optionally, but we weren't passing the optional injector flag.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 8, 2021
@crisbeto crisbeto requested a review from jelbourn as a code owner June 8, 2021 14:37
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 8, 2021
wagnermaciel
wagnermaciel approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2021
jelbourn
jelbourn approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit fc8a6f9 into angular:master Jun 10, 2021
wagnermaciel pushed a commit that referenced this pull request Jun 10, 2021
@crisbeto @wagnermaciel
fix(multiple): add inject flags to manual injector calls (#22922)
2e2f755 
Fixes a few more cases like #22665 where we were injecting something optionally, but we weren't passing the optional injector flag.

(cherry picked from commit fc8a6f9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @andrewseguin @wagnermaciel