Skip to content

refactor(material/progress-spinner): clean up IE workarounds #23283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

refactor(material/progress-spinner): clean up IE workarounds #23283

merged 1 commit into from
Aug 4, 2021

Conversation

crisbeto
Copy link
Member

Cleans up the various workarounds for IE from the progress spinner.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Jul 30, 2021
@crisbeto crisbeto requested a review from jelbourn July 30, 2021 18:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2021
@crisbeto
refactor(material/progress-spinner): clean up IE workarounds
72a8748 
Cleans up the various workarounds for IE from the progress spinner.
@crisbeto crisbeto force-pushed the progress-spinner-ie branch from 2d40b6e to 72a8748 Compare July 30, 2021 19:10
@crisbeto crisbeto requested a review from a team as a code owner July 30, 2021 19:10
jelbourn
jelbourn approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2021
devversion
devversion approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zarend zarend merged commit 45f3bf9 into angular:master Aug 4, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @zarend