Skip to content

build: migrate to use the new layout of the @angular/dev-infra-private package #23321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

build: migrate to use the new layout of the @angular/dev-infra-private package #23321

merged 1 commit into from
Aug 13, 2021

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added blocked This issue is blocked by some external factor, such as a prerequisite PR target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Aug 6, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2021
@josephperrott josephperrott force-pushed the migrate-dev-infra branch 4 times, most recently from 2d796fb to 3b11980 Compare August 6, 2021 14:51
@josephperrott josephperrott removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 6, 2021
@josephperrott josephperrott marked this pull request as ready for review August 6, 2021 15:22
@josephperrott josephperrott requested a review from a team as a code owner August 6, 2021 15:22
devversion
devversion approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@josephperrott josephperrott force-pushed the migrate-dev-infra branch 3 times, most recently from 084f757 to fc923d0 Compare August 11, 2021 22:03
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker merge safe labels Aug 11, 2021
@zarend
Copy link
Contributor

zarend commented Aug 13, 2021

@josephperrott , I'm unable to merge this because it has conflicts with master 😢 . Please resolve the merge conflicts.

@zarend zarend added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 13, 2021
@zarend zarend merged commit fe32843 into angular:master Aug 13, 2021
@josephperrott josephperrott deleted the migrate-dev-infra branch August 13, 2021 17:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperrott @zarend @devversion