Skip to content

fix(material/checkbox): hide svg from assistive technology #23340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix(material/checkbox): hide svg from assistive technology #23340

merged 1 commit into from
Aug 18, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the svg node inside of the checkbox might be read out by some screen readers.

Fixes #23338.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Aug 11, 2021
@crisbeto crisbeto requested a review from jelbourn August 11, 2021 03:17
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 11, 2021
@zelliott
Copy link
Collaborator

LGTM

devversion
devversion approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. do we need the same for the checkbox in the mdc-list?

@crisbeto
fix(material/checkbox): hide svg from assistive technology
0e790d4 
Fixes that the `svg` node inside of the checkbox might be read out by some screen readers.

Fixes angular#23338.
@crisbeto crisbeto force-pushed the 23338/checkbox-hidden-svg branch from f028b7e to 0e790d4 Compare August 11, 2021 20:25
@crisbeto
Copy link
Member Author

That's a good point I hadn't considered. I've added it now.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2021
jelbourn
jelbourn approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mmalerba
mmalerba approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit 8bd8f75 into angular:master Aug 18, 2021
wagnermaciel pushed a commit that referenced this pull request Aug 18, 2021
@crisbeto @wagnermaciel
fix(material/checkbox): hide svg from assistive technology (#23340)
08ef775 
Fixes that the `svg` node inside of the checkbox might be read out by some screen readers.

Fixes #23338.

(cherry picked from commit 8bd8f75)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(material/checkbox): VoiceOver interprets the SVG inside a checkbox as an "empty unlabelled image"
6 participants
@crisbeto @zelliott @jelbourn @devversion @mmalerba @wagnermaciel