Skip to content

fix(material/datepicker): wrong day of week read out for dates in first row #23388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

crisbeto
Copy link
Member

The first row of cells has a cell with the month label which also has a colspan and aria-hidden. It looks like hiding the cell causes screen readers to ignore the cell competely and consider the cells after it to be first. This results in the wrong day of the week being read out for each date.

…st row

The first row of cells has a cell with the month label which also has a `colspan` and `aria-hidden`. It looks like hiding the cell causes screen readers to ignore the cell competely and consider the cells after it to be first. This results in the wrong day of the week being read out for each date.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Aug 17, 2021
@crisbeto crisbeto requested a review from mmalerba August 17, 2021 15:31
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 17, 2021
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 17, 2021
@wagnermaciel wagnermaciel merged commit e791236 into angular:master Aug 18, 2021
wagnermaciel pushed a commit that referenced this pull request Aug 18, 2021
…st row (#23388)

The first row of cells has a cell with the month label which also has a `colspan` and `aria-hidden`. It looks like hiding the cell causes screen readers to ignore the cell competely and consider the cells after it to be first. This results in the wrong day of the week being read out for each date.

(cherry picked from commit e791236)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants