Skip to content

build: bump size test goldens #23542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2021
Merged

build: bump size test goldens #23542

merged 1 commit into from
Sep 10, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 7, 2021

Updates the size test goldens since we hadn't touched them in some time.

@crisbeto
build: bump size test goldens
adec06d 
Updates the size test goldens since we hadn't touched them in some time.
@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Sep 7, 2021
@crisbeto crisbeto requested a review from devversion September 7, 2021 21:13
@crisbeto crisbeto requested a review from a team as a code owner September 7, 2021 21:13
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 7, 2021
devversion
devversion approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think it's still good to update them from time to time (like you do) as it allows us to see if anything drastically increased.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 8, 2021
@andrewseguin andrewseguin merged commit 7f698e1 into angular:master Sep 10, 2021
andrewseguin pushed a commit that referenced this pull request Sep 10, 2021
@crisbeto @andrewseguin
build: bump size test goldens (#23542)
b6de384 
Updates the size test goldens since we hadn't touched them in some time.

(cherry picked from commit 7f698e1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @andrewseguin