refactor: remove tilde import usages #23702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the tilde imports from all docs and schematics since they're deprecated and they may cause build issues in the future. Also reworks the theming API migration to handle tilde imports.
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
devversion
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
LGTM. I can confirm that we would not require users to add node_modules as Sass include path because the Webpack Sass loader will try resolving e.g. @angular/material as a module.
We just need to make sure to have the proper package exports defined with APF v13.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the tilde imports from all docs and schematics since they're deprecated and they may cause build issues in the future.
Also reworks the theming API migration to handle tilde imports.