Skip to content

fix(cdk/portal): corrected mistake in Portal code template example #23818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2021
Merged

fix(cdk/portal): corrected mistake in Portal code template example #23818

merged 1 commit into from
Oct 24, 2021

Conversation

vakhramoff
Copy link
Contributor

There was a slight mistake in a generic type so I fixed it.

@vakhramoff vakhramoff requested a review from jelbourn as a code owner October 22, 2021 19:32
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2021
@vakhramoff
Copy link
Contributor Author

@crisbeto I cannot add any labels or do anything with my PR, maybe you could look at it? It's so tiny ☺️

crisbeto
crisbeto approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Oct 23, 2021
@wagnermaciel wagnermaciel merged commit 2e2fcc8 into angular:master Oct 24, 2021
wagnermaciel pushed a commit that referenced this pull request Oct 24, 2021
@wagnermaciel
fix(cdk/portal): write generic type for TemplateRef in the Template P…
c4cb63b 
…ortal code example (#23818)

(cherry picked from commit 2e2fcc8)
wagnermaciel pushed a commit that referenced this pull request Oct 24, 2021
@wagnermaciel
fix(cdk/portal): write generic type for TemplateRef in the Template P…
6161ec6 
…ortal code example (#23818)

(cherry picked from commit 2e2fcc8)
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vakhramoff @crisbeto @wagnermaciel