build: add unlisted dependencies to package.json #24152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `@angular/platform-browser` to the `material` package.json since we have dependencies on it in a lot of modules. * Adds several missing dependencies (`animations`, `cdk`, `common`, `forms` and `platform-browser`) to the package.json in `material-experimental`. Fixes angular#24146.
crisbeto
added
P3
crisbeto
commented
Jan 3, 2022
| "@angular/core": "0.0.0-NG", | ||
| "@angular/common": "0.0.0-NG", | ||
| "@angular/forms": "0.0.0-NG", | ||
| "@angular/platform-browser": "0.0.0-NG", |
There was a problem hiding this comment.
Technically these are already listed as peerDependencies on @angular/material which was already listed, but it might be better to list them explicitly.
devversion
approved these changes
Jan 3, 2022
wagnermaciel
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Adds `@angular/platform-browser` to the `material` package.json since we have dependencies on it in a lot of modules. * Adds several missing dependencies (`animations`, `cdk`, `common`, `forms` and `platform-browser`) to the package.json in `material-experimental`. Fixes #24146. (cherry picked from commit 6e62a03)
|
Thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angular/platform-browserto thematerialpackage.json since we have dependencies on it in a lot of modules.animations,cdk,common,formsandplatform-browser) to the package.json inmaterial-experimental.Fixes #24146.