Skip to content

fix(cdk/schematics): remove file extensions in tilde migration #24169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(cdk/schematics): remove file extensions in tilde migration #24169

merged 1 commit into from
Jan 7, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 6, 2022

Expands the tilde migration to also drop the .scss file extensions.

Fixes #24162.

@crisbeto
fix(cdk/schematics): remove file extensions in tilde migration
a006c15 
Expands the tilde migration to also drop the `.scss` file extensions.

Fixes angular#24162.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jan 6, 2022
@crisbeto crisbeto requested a review from devversion January 6, 2022 11:06
@crisbeto crisbeto requested a review from jelbourn as a code owner January 6, 2022 11:06
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 6, 2022
@wagnermaciel wagnermaciel merged commit 4132006 into angular:master Jan 7, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 7, 2022
@crisbeto @wagnermaciel
fix(cdk/schematics): remove file extensions in tilde migration (#24169)
af18823 
Expands the tilde migration to also drop the `.scss` file extensions.

Fixes #24162.

(cherry picked from commit 4132006)
zarend pushed a commit to zarend/components that referenced this pull request Jan 7, 2022
@crisbeto @zarend
fix(cdk/schematics): remove file extensions in tilde migration (angul…
753ecf9 
…ar#24169)

Expands the tilde migration to also drop the `.scss` file extensions.

Fixes angular#24162.
jeripeierSBB added a commit to sbb-design-systems/sbb-angular that referenced this pull request Jan 10, 2022
@jeripeierSBB
fix(angular/schematics): remove file extensions in tilde migration
64d4efa 
angular/components#24169
@jeripeierSBB jeripeierSBB mentioned this pull request Jan 10, 2022
Merged
jeripeierSBB added a commit to sbb-design-systems/sbb-angular that referenced this pull request Jan 11, 2022
@jeripeierSBB
fix(angular/schematics): remove file extensions in tilde migration (#…
ba01867 
…1008)

angular/components#24169
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(scss): ng update @angular/cdk did not remove .scss extension imports which breaks the application after serving.
3 participants
@crisbeto @devversion @wagnermaciel