Skip to content

fix(cdk/table): revert breaking change of CdkTable constructor #24202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged

fix(cdk/table): revert breaking change of CdkTable constructor #24202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cdk/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDes
* @breaking-change 14.0.0
*/
@Optional()
protected readonly _ngZone: NgZone,
protected readonly _ngZone?: NgZone,
) {
if (!role) {
this._elementRef.nativeElement.setAttribute('role', 'table');
Expand Down
4 changes: 2 additions & 2 deletions tools/public_api_guard/cdk/table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export class CdkRowDef<T> extends BaseRowDef {
export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDestroy, OnInit {
constructor(_differs: IterableDiffers, _changeDetectorRef: ChangeDetectorRef, _elementRef: ElementRef, role: string, _dir: Directionality, _document: any, _platform: Platform, _viewRepeater: _ViewRepeater<T, RenderRow<T>, RowContext<T>>, _coalescedStyleScheduler: _CoalescedStyleScheduler, _viewportRuler: ViewportRuler,
_stickyPositioningListener: StickyPositioningListener,
_ngZone: NgZone);
_ngZone?: NgZone | undefined);
addColumnDef(columnDef: CdkColumnDef): void;
addFooterRowDef(footerRowDef: CdkFooterRowDef): void;
addHeaderRowDef(headerRowDef: CdkHeaderRowDef): void;
Expand Down Expand Up @@ -334,7 +334,7 @@ export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDes
// (undocumented)
ngOnInit(): void;
// @deprecated (undocumented)
protected readonly _ngZone: NgZone;
protected readonly _ngZone?: NgZone | undefined;
_noDataRow: CdkNoDataRow;
// (undocumented)
_noDataRowOutlet: NoDataRowOutlet;
Expand Down