Skip to content

fix(select): not trimming long labels #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2017
Merged

fix(select): not trimming long labels #2444

merged 2 commits into from
Jan 20, 2017

Conversation

crisbeto
Copy link
Member

  • Fixes long text not being trimmed inside of md-option, because the element is a flex container. Switches it to display: block and uses line-height to center the text.
  • Fixes the selected value not being trimmed, because the element doesn't have a defined width.

Fixes #2440.

@crisbeto crisbeto requested a review from kara December 28, 2016 11:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2016
@crisbeto crisbeto mentioned this pull request Jan 19, 2017
Merged
@kara
Copy link
Contributor

kara commented Jan 19, 2017 •
edited
Loading

@crisbeto This seems to throw off the alignment of icons in md-menu. Can you fix? I think it's the line height.

@kara kara assigned crisbeto and unassigned kara Jan 19, 2017
@crisbeto
fix(select): not trimming long labels
2363f18 
* Fixes long text not being trimmed inside of `md-option`, because the element is a flex container. Switches it to `display: block` and uses `line-height` to center the text.
* Fixes the selected value not being trimmed, because the element doesn't have a defined width.

Fixes angular#2440.
@crisbeto crisbeto force-pushed the 2440/select-ellipsis branch from e367278 to 2363f18 Compare January 19, 2017 20:27
@crisbeto crisbeto assigned kara and unassigned crisbeto Jan 19, 2017
@crisbeto
Copy link
Member Author

Fixed @kara.

kara
kara approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 19, 2017
@kara kara removed their assignment Jan 19, 2017
@mmalerba mmalerba merged commit 416f56f into angular:master Jan 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MdSelect does not handle long text well
4 participants
@crisbeto @kara @googlebot @mmalerba