Skip to content

Conversation

wagnermaciel
Copy link
Contributor

  • create ComponentMigrator interface to store the
    different types of migrations for each component
  • refactor individual migrations to work with ComponentMigrator
  • add missing unit test for addAttribute
  • create TemplateMigrator to unify the interface
    for template migrations

@wagnermaciel wagnermaciel added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 10, 2022
Copy link
Contributor

@amysorto amysorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* create ComponentMigrator interface to store the
  different types of migrations for each component
* refactor individual migrations to work with ComponentMigrator
* add missing unit test for addAttribute
* create TemplateMigrator to unify the interface
  for template migrations
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wagnermaciel wagnermaciel merged commit dbade7d into angular:mdc-migration Mar 10, 2022
devversion pushed a commit to devversion/material2 that referenced this pull request Mar 14, 2022
…ar#24563)

* create ComponentMigrator interface to store the
  different types of migrations for each component
* refactor individual migrations to work with ComponentMigrator
* add missing unit test for addAttribute
* create TemplateMigrator to unify the interface
  for template migrations
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants