Skip to content

build: cleanup preview dev-app github action workflow #24582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

build: cleanup preview dev-app github action workflow #24582

merged 1 commit into from
Mar 14, 2022

Conversation

devversion
Copy link
Member

We can remove the GITHUB_ENV sourcing since we changed how
RBE is configured: 26fc03e

@devversion
build: cleanup preview dev-app github action workflow
24f4bbb 
We can remove the `GITHUB_ENV` sourcing since we changed how
RBE is configured: 26fc03e
@devversion devversion added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Mar 12, 2022
@github-actions
Copy link

Deployed dev-app to: https://ng-comp-dev--pr-24582-24f4bbbb0bfbe152200b0e3194de98d7-a2kxmh78.web.app

@devversion devversion marked this pull request as ready for review March 12, 2022 13:10
@devversion devversion requested a review from a team as a code owner March 12, 2022 13:10
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 12, 2022
@devversion devversion requested a review from crisbeto March 12, 2022 13:10
crisbeto
crisbeto approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2022
josephperrott
josephperrott approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend merged commit f1ec0fc into angular:master Mar 14, 2022
zarend pushed a commit that referenced this pull request Mar 14, 2022
@devversion @zarend
build: cleanup preview dev-app github action workflow (#24582)
d5673bb 
We can remove the `GITHUB_ENV` sourcing since we changed how
RBE is configured: 26fc03e

(cherry picked from commit f1ec0fc)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@devversion @forsti0506
build: cleanup preview dev-app github action workflow (angular#24582)
48038f6 
We can remove the `GITHUB_ENV` sourcing since we changed how
RBE is configured: 26fc03e
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @crisbeto @josephperrott @zarend