fix(material/schematics): add attr for multi-line start tags #24586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Mar 14, 2022
wagnermaciel
commented
- add logic for handling multi-line start tags in #addAttribute
- unit tested
- delete unused template-migration.spec.ts file
* add logic for handling multi-line start tags in #addAttribute * unit tested * delete unused template-migration.spec.ts file
devversion
reviewed
Mar 14, 2022
src/material/schematics/ng-generate/mdc-migration/rules/tree-traversal.ts
Outdated
Show resolved
Hide resolved
wagnermaciel
added
the
target: feature
devversion
approved these changes
Mar 15, 2022
|
|
||
| const attr = node.attributes[0]; | ||
| const ctx = attr.sourceSpan.start.getContext(attr.sourceSpan.start.col + 1, 1)!; | ||
| const indentation = ctx.before; |
There was a problem hiding this comment.
Nice, now we were able to also limit the getContext invocation more. I was initially thinking we'd just do something like ' '.repeat(columns + 1) but copying the original indentation makes sense (if e.g. tabs are used).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.