Skip to content

fix(cdk/portal): prevent calling ApplicationRef.detachView on destroyed instance #24775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix(cdk/portal): prevent calling ApplicationRef.detachView on destroyed instance #24775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cdk/portal/dom-portal-outlet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ export class DomPortalOutlet extends BasePortalOutlet {
);
this._appRef!.attachView(componentRef.hostView);
this.setDisposeFn(() => {
this._appRef!.detachView(componentRef.hostView);
// Verify that the ApplicationRef has registered views before trying to detach a host view.
// This check also protects the `detachView` from being called on a destroyed ApplicationRef.
if (this._appRef!.viewCount > 0) {
this._appRef!.detachView(componentRef.hostView);
}
componentRef.destroy();
});
}
Expand Down