Skip to content

build: fix staging release checks after auto-generating material-experimental package json #24846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

devversion
Copy link
Member

We recently started auto-generating the material-experimental
package.json file to avoid duplicating the MDC version/deps
across multiple places.

The staging checks assume a package.json file to be visible in the
source files. For our checks it is sufficient to use the handwritten
base package.json file.

Note: We do have actual generated package.json tests, but these tests
are quick sanity checks that run before actually releasing (giving a quick
heads-up before doing too much unnecessary work)

…erimental` package json

We recently started auto-generating the material-experimental
package.json file to avoid duplicating the MDC version/deps
across multiple places.

The staging checks assume a `package.json` file to be visible in the
source files. For our checks it is sufficient to use the handwritten
base package.json file.
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels Apr 28, 2022
@devversion devversion requested a review from a team as a code owner April 28, 2022 10:53
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2022
@andrewseguin andrewseguin merged commit 86aa9c1 into angular:master Apr 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants