Skip to content

docs(material/theming): fix typo in theming guide #25685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

docs(material/theming): fix typo in theming guide #25685

merged 1 commit into from
Oct 4, 2022

Conversation

titosx
Copy link
Contributor

@titosx titosx commented Sep 23, 2022

In theming guide the mat.get-color-from-palette is shown with a number identifier in quotes, unlike the theming-your-components guide which shows it without quotes.

Fixes #25598

@titosx
docs(material/theming): fix typo in theming guide
c685ae5 
In theming guide the mat.get-color-from-palette is shown with a number identifier in quotes, unlike the theming-your-components guide which shows it without quotes.

Fixes #25598
@titosx titosx requested a review from jelbourn as a code owner September 23, 2022 09:58
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 23, 2022
jelbourn
jelbourn approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn mentioned this pull request Oct 3, 2022
Closed
@jelbourn jelbourn added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release and removed area: docs Related to the documentation labels Oct 3, 2022
@wagnermaciel wagnermaciel merged commit 4d9e797 into angular:main Oct 4, 2022
wagnermaciel pushed a commit that referenced this pull request Oct 4, 2022
@titosx @wagnermaciel
docs(material/theming): fix typo in theming guide (#25685)
7e56c55 
In theming guide the mat.get-color-from-palette is shown with a number identifier in quotes, unlike the theming-your-components guide which shows it without quotes.

Fixes #25598

(cherry picked from commit 4d9e797)
@titosx titosx deleted the theming branch October 15, 2022 18:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mat.Get-Color-From-Palette($palette, $hue) -- $hue number cannot be string
3 participants
@titosx @jelbourn @wagnermaciel