fix(material/schematics): migrate named arguments in define-typography-config #25907
Conversation
crisbeto
added
P2
…y-config `define-typography-config` changed the names of the typography levels in MDC which is a breaking change. This fix adds a migration to remap the arguments to their new names.
crisbeto
force-pushed
the
mdc-migration-typography
branch
from
87ebd1b to
ba302cf
Compare
| * Mapping between the renamed legacy typography levels and their new non-legacy names. Based on | ||
| * the mappings in `private-typography-to-2018-config` from `core/typography/_typography.scss`. | ||
| */ | ||
| const RENAMED_TYPOGRAPHY_LEVELS = new Map([ |
There was a problem hiding this comment.
I know the non MDC typography levels have input but is not in the new one/being mapped. Is it just not able to be mapped? If so, we should probably add it somewhere in the migration doc.
There was a problem hiding this comment.
Ah, good catch. I'm leaning more towards adding an input level to the MDC config. I'll merge in the PR as is for now and will ping Miles when he's back since he set up the MDC configs.
There was a problem hiding this comment.
Resolution: the schematic should remap input to body-1.
|
thank you @crisbeto ! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
define-typography-configchanged the names of the typography levels in MDC which is a breaking change. This fix adds a migration to remap the arguments to their new names.