Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 2, 2022

Switches the Overlay injectable to be provided at the root.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Nov 2, 2022
@crisbeto crisbeto requested a review from jelbourn as a code owner November 2, 2022 13:24
Switches the `Overlay` injectable to be provided at the root.
@crisbeto crisbeto force-pushed the overlay-providedin-root branch from fbb5cab to 0e11a4b Compare November 2, 2022 15:35
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2022
@crisbeto crisbeto merged commit 5942ebf into angular:main Nov 2, 2022
crisbeto added a commit that referenced this pull request Nov 2, 2022
Switches the `Overlay` injectable to be provided at the root.

(cherry picked from commit 5942ebf)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants